Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): remove leading dollar sign #226

Merged
merged 1 commit into from Jun 24, 2022
Merged

chore(docs): remove leading dollar sign #226

merged 1 commit into from Jun 24, 2022

Conversation

nhedger
Copy link
Contributor

@nhedger nhedger commented Jun 20, 2022

@nhedger nhedger mentioned this pull request Jun 20, 2022
Merged
clue
clue approved these changes Jun 20, 2022
View reviewed changes
Copy link
Member

@clue clue left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nhedger Thanks for looking into this! 👍

We should also apply the same changes to the 3.x and 1.x branches 👍

@clue clue added this to the v2.10.0 milestone Jun 20, 2022
@clue clue requested a review from WyriHaximus June 20, 2022 14:48
@WyriHaximus WyriHaximus merged commit 3320514 into reactphp:2.x Jun 24, 2022
@nhedger nhedger deleted the chore/remove-dollar-sign branch June 24, 2022 09:59
@clue
Copy link
Member

clue commented Jun 27, 2022

@nhedger Glad this has been merged! Can you also apply the same changes to the 3.x and 1.x branches? 👍

@nhedger nhedger mentioned this pull request Jun 28, 2022
Merged
@nhedger
Copy link
Contributor Author

nhedger commented Jun 28, 2022 •
edited

@clue PR for 3.x is here: #231.

The 1.x branch does not look like it needs any modifications though. It does not have the usual installation instructions in which these code blocks can be found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WyriHaximus WyriHaximus WyriHaximus approved these changes

@clue clue clue approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
v2.10.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nhedger @clue @WyriHaximus