Merge pull request #38 from clue-labs/garbage

Update test suite to collect all garbage cycles
reactphp · Jul 11, 2023 · e032661 · e032661
2 parents 87d1399 + b3b070a
commit e032661
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/tests/FirstTest.php b/tests/FirstTest.php
@@ -115,7 +115,9 @@ public function testCancelPendingStreamWillReject()
 
     public function testShouldResolveWithoutCreatingGarbageCyclesAfterDataThenClose()
     {
-        \gc_collect_cycles();
+        while (gc_collect_cycles()) {
+            // collect all garbage cycles
+        }
 
         $stream = new ThroughStream();
 
@@ -130,7 +132,10 @@ public function testShouldResolveWithoutCreatingGarbageCyclesAfterDataThenClose(
 
     public function testCancelPendingStreamWillRejectWithoutCreatingGarbageCycles()
     {
-        \gc_collect_cycles();
+        while (gc_collect_cycles()) {
+            // collect all garbage cycles
+        }
+
         $stream = new ThroughStream();
 
         $promise = Stream\first($stream);