Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor HTTP message parsing to build on top of new PSR-7 implementation #520

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

clue
Copy link
Member

@clue clue commented Mar 22, 2024

This changeset refactors the HTTP message parsing logic in the internal ClientRequestStream and RequestHeaderParser classes to build on top of a new PSR-7 implementation. This brings us one step closer to eventually replace the dated RingCentral implementation (#331) and eventually support PSR-7 v2 (#513). Most notably, this means the Browser will now return instances of our Response class (#518) instead of using the legacy RingCentral classes.

Other than that, this is a purely internal change that comes with 100% code coverage and does not otherwise affect the public API, so it should be safe to apply. I've tried to keep changes to a minimum to ease review, but there's definitely some room for improvement in follow-up PRs.

This builds on top of the recent changes for the Response and ServerRequest classes (#518 and #519), but this time doesn't show a noticeable impact on performance during my benchmarks. As a consequence, I consider this mostly an internal refactoring only.

Once merged, I'll file follow-up PRs to refactor the Uri class accordingly. If you enjoy this change and want to help us continue to ship more improvements, consider supporting this project, for example by becoming a sponsor ❤️

Builds on top of #519, #518, #480, #432, #370, #170 and others

Copy link
Member

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through all changes, looks good so let's get this shipped 👍

Copy link
Member

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants