Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #504 laravel + websockets: Unhandled promise rejection with TypeError #506

Closed
wants to merge 1 commit into from

Conversation

SocolaDaiCa
Copy link

@SocolaDaiCa SocolaDaiCa commented Oct 11, 2023

@SocolaDaiCa SocolaDaiCa changed the title fix: #504 aravel + websockets: Unhandled promise rejection with TypeError fix: #504 laravel + websockets: Unhandled promise rejection with TypeError Oct 11, 2023
@SimonFrings
Copy link
Member

@SocolaDaiCa thanks for trying to fix the issue reported in #504 👍

I just gave an explanation in #504 why this isn't really a bug in our HTTP component and should be reported downstream in https://github.com/beyondcode/laravel-websockets instead.

I can totally understand the reason behind this pull request, as it makes sense that we should support Throwables instead of just exceptions. Raising the PHP version from PHP 5.3 to PHP 7 is at least a BC break and I don't think we want to go this step for the current v1.

We're currently working on ReactPHP v3 which will raise the minimal supported PHP version to PHP 7.1 anyway, so I think we might want to take a look at this over there. We also have plans to improve the error reporting for v3, so I think we will pick this up in the upcoming weeks/months. The v3 roadmap ticket for HTTP is still outstanding but will drop soon.

With all that said, I'll close this ticket for now and we'll have a look at this as we move forward with ReactPHP v3 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants