Add LimitConcurrentRequestsMiddleware to limit how many next handlers can be executed concurrently #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WyriHaximus
requested changes
Dec 8, 2017
| $pending--; | ||
| $that->processQueue(); | ||
|
|
||
| throw $error; |
There was a problem hiding this comment.
This seems to cause build errors on PHP versions below 7: https://travis-ci.org/reactphp/http/jobs/313201152#L517
There was a problem hiding this comment.
Indeed, updated to explicitly reject() in case the rejection value is not an Exception: https://github.com/reactphp/http/pull/272/files#diff-ab60bdad04437904e8a3c3e4c8eff52fR137 
WyriHaximus
requested changes
Dec 8, 2017
| $once = $this->expectCallableOnce(); | ||
| $deferred = new Deferred(function () use ($once) { | ||
| $once(); | ||
| throw new RuntimeException('Cancelled'); |
There was a problem hiding this comment.
Travis is crashing on this: https://travis-ci.org/reactphp/http/jobs/313374574#L512
There was a problem hiding this comment.
Duh, updated invalid reference just now
clue
changed the title
|
Rebased to resolve merge conflict with #264 |
jsor
reviewed
Dec 8, 2017
README.md
Outdated
| ])); | ||
| ``` | ||
|
|
||
| More sophisticated examples include limiting the total number of of requests |
src/Io/PauseBufferStream.php
Outdated
| * | ||
| * This class is used to buffer all events that happen on a given stream while | ||
| * it is paused. This allows you to pause a stream and no longer watch for any | ||
| * of its events. Once the stream is resumed, all buffered event will be |
| * ])); | ||
| * ``` | ||
| * | ||
| * More sophisticated examples include limiting the total number of of requests |
|
Thanks for spotting, updated |
|
🚨 Merge conflicts 🚨 |
|
Rebased to resolve merge conflict now that #274 is in |
jsor
approved these changes
Dec 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new ~~~
LimitHandlersMiddleware(name subject to discussion / change)~~~LimitConcurrentRequestsMiddlewareallows consumers to limit how many next handlers can be executed concurrently. This can be useful in a streaming context, where the number of concurrent buffers have to be limited. Or if can be used to avoid concurrent execution of handlers entirely. See also README changes for more details.Accordingly, this functionality is also a requirement for implementing a buffering server (via #259). This allows you to limit this so that for example up to 100 requests with a maximum of 2 MiB each can be buffered and may take up to 200 MiB concurrently.
In a follow-up PR, we will eventually implement similar logic to limit total memory consumption instead. This will allow a higher concurrency under the reasonable assumption that many requests are way below a given limit (see #255).
Supersedes / closes #218, thanks @WyriHaximus!
Refs #194
Refs #259