Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP client: Support HTTP upgrades (WebSockets) #376

Open
clue opened this issue Jul 12, 2020 · 1 comment
Open

HTTP client: Support HTTP upgrades (WebSockets) #376

clue opened this issue Jul 12, 2020 · 1 comment
Labels
help wanted HTTP/1.1 new feature

Comments

@clue
Copy link
Member

clue commented Jul 12, 2020 •
edited

This library should provide support for HTTP upgrades (WebSocket etc.) using the Connection: upgrade and Upgrade: websocket headers.

This is already supported on the server-side (see #190), so adding support for this on the client-side should be reasonable. This will likely require a dedicated API as the existing streaming APIs only expose a ReadableStreamInterface and the upgraded stream would have to be a DuplexStreamInterface.

We welcome contributions, reach out if you want to support this project 👍
This was referenced Jul 12, 2020
Closed
Open
Closed
@bosunski
Copy link

The good news is that I was able to have a working implementation of this during the weekend 😀. I'm currently testing and hope to get a PR in by tomorrow.

@bosunski bosunski mentioned this issue Jul 27, 2020
Closed
@clue clue mentioned this issue Aug 28, 2020
Merged
@clue clue mentioned this issue Aug 24, 2021
Open
@clue clue added the HTTP/1.1 label Aug 24, 2021
This was referenced Jan 18, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted HTTP/1.1 new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@clue @bosunski