Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.2.x] Support Promise v3 #116

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

WyriHaximus
Copy link
Member

@WyriHaximus WyriHaximus commented Jan 29, 2024

Brings support for Promise v3 to the filesystem package.

@WyriHaximus WyriHaximus added this to the v0.2.0 milestone Jan 29, 2024
@WyriHaximus WyriHaximus force-pushed the 0.2.x-promise-v3 branch 6 times, most recently from 854dfcc to b6f1aed Compare January 29, 2024 13:34
Brings support for Promise v3 to the filesystem package.
@WyriHaximus WyriHaximus marked this pull request as ready for review January 29, 2024 14:20
@pfk84
Copy link

pfk84 commented Mar 16, 2024

Great! Any plans on when this will be available on packagist?

Copy link
Member

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WyriHaximus I don't think this is currently tested in our test matrix because this project still contains a composer.lock with Promise v2, but if you confirm this is tested, I think this is good to go 👍

@clue clue merged commit 385933f into reactphp:0.2.x Mar 26, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants