Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use reactphp/async instead of clue/reactphp-block #53

Merged
merged 1 commit into from Nov 22, 2022
Merged

Use reactphp/async instead of clue/reactphp-block #53

merged 1 commit into from Nov 22, 2022

Conversation

dinooo13
Copy link
Contributor

@dinooo13 dinooo13 commented Sep 30, 2022 •
edited

@SimonFrings
Copy link
Member

@dinooo13 Thanks for this PR, can you add some references in your PR description similar to my comment in clue/reactphp-mq#34.

@dinooo13
Copy link
Contributor Author

dinooo13 commented Nov 19, 2022 •
edited

Updated with 1.x, please re-review.

SimonFrings
SimonFrings approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@SimonFrings SimonFrings added this to the v1.9.0 milestone Nov 21, 2022
clue
clue reviewed Nov 21, 2022
View reviewed changes
Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dinooo13 Changes LGTM, may I ask you to rebase/squash this into a single commit? 👍

@dinooo13
Copy link
Contributor Author

squashed 👍🏼

@dinooo13 dinooo13 requested a review from clue November 21, 2022 20:11
clue
clue approved these changes Nov 22, 2022
View reviewed changes
Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dinooo13 Thanks for the update, keep it up! :shipit:

@clue clue merged commit afc1f1d into reactphp:1.x Nov 22, 2022
@dinooo13 dinooo13 deleted the async branch November 22, 2022 13:51
@clue clue mentioned this pull request Dec 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WyriHaximus WyriHaximus WyriHaximus approved these changes

@clue clue clue approved these changes

@SimonFrings SimonFrings SimonFrings approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
v1.9.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dinooo13 @SimonFrings @WyriHaximus @clue