Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip failing tests on bugged versions (PHP 8.1.8) #98

Merged
merged 1 commit into from Aug 10, 2022
Merged

Skip failing tests on bugged versions (PHP 8.1.8) #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/AbstractProcessTest.php
View file
Open in desktop
Expand Up @@ -643,7 +643,7 @@ public function testDetectsClosingStdoutWithoutHavingToWaitForExit()
$this->markTestSkipped('Process pipes not supported on Windows');
}

if (PHP_VERSION_ID === 80107 || PHP_VERSION_ID === 80020) {
if (PHP_VERSION_ID === 80108 || PHP_VERSION_ID === 80107 || PHP_VERSION_ID === 80020) {
$this->markTestSkipped('Skip bugged PHP version: https://github.com/php/php-src/issues/8827');
}

Expand Down Expand Up @@ -673,7 +673,7 @@ public function testDetectsClosingStdoutWithoutHavingToWaitForExit()
*/
public function testDetectsClosingStdoutSocketWithoutHavingToWaitForExit()
{
if (PHP_VERSION_ID === 80107 || PHP_VERSION_ID === 80020) {
if (PHP_VERSION_ID === 80108 || PHP_VERSION_ID === 80107 || PHP_VERSION_ID === 80020) {
$this->markTestSkipped('Skip bugged PHP version: https://github.com/php/php-src/issues/8827');
}

Expand Down Expand Up @@ -711,7 +711,7 @@ public function testKeepsRunningEvenWhenAllStdioPipesHaveBeenClosed()
$this->markTestSkipped('Process pipes not supported on Windows');
}

if (PHP_VERSION_ID === 80107 || PHP_VERSION_ID === 80020) {
if (PHP_VERSION_ID === 80108 || PHP_VERSION_ID === 80107 || PHP_VERSION_ID === 80020) {
$this->markTestSkipped('Skip bugged PHP version: https://github.com/php/php-src/issues/8827');
}

Expand Down Expand Up @@ -750,7 +750,7 @@ public function testKeepsRunningEvenWhenAllStdioPipesHaveBeenClosed()
*/
public function testKeepsRunningEvenWhenAllStdioSocketsHaveBeenClosed()
{
if (PHP_VERSION_ID === 80107 || PHP_VERSION_ID === 80020) {
if (PHP_VERSION_ID === 80108 || PHP_VERSION_ID === 80107 || PHP_VERSION_ID === 80020) {
$this->markTestSkipped('Skip bugged PHP version: https://github.com/php/php-src/issues/8827');
}

Expand Down