Skip to content

Commit

Permalink
Merge pull request #98 from clue-labs/tests
Browse files Browse the repository at this point in the history
Skip failing tests on bugged versions (PHP 8.1.8)
  • Loading branch information
WyriHaximus committed Aug 10, 2022
2 parents 8280258 + 5d33ec9 commit 1c46b3b
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions tests/AbstractProcessTest.php
Expand Up @@ -643,7 +643,7 @@ public function testDetectsClosingStdoutWithoutHavingToWaitForExit()
$this->markTestSkipped('Process pipes not supported on Windows');
}

if (PHP_VERSION_ID === 80107 || PHP_VERSION_ID === 80020) {
if (PHP_VERSION_ID === 80108 || PHP_VERSION_ID === 80107 || PHP_VERSION_ID === 80020) {
$this->markTestSkipped('Skip bugged PHP version: https://github.com/php/php-src/issues/8827');
}

Expand Down Expand Up @@ -673,7 +673,7 @@ public function testDetectsClosingStdoutWithoutHavingToWaitForExit()
*/
public function testDetectsClosingStdoutSocketWithoutHavingToWaitForExit()
{
if (PHP_VERSION_ID === 80107 || PHP_VERSION_ID === 80020) {
if (PHP_VERSION_ID === 80108 || PHP_VERSION_ID === 80107 || PHP_VERSION_ID === 80020) {
$this->markTestSkipped('Skip bugged PHP version: https://github.com/php/php-src/issues/8827');
}

Expand Down Expand Up @@ -711,7 +711,7 @@ public function testKeepsRunningEvenWhenAllStdioPipesHaveBeenClosed()
$this->markTestSkipped('Process pipes not supported on Windows');
}

if (PHP_VERSION_ID === 80107 || PHP_VERSION_ID === 80020) {
if (PHP_VERSION_ID === 80108 || PHP_VERSION_ID === 80107 || PHP_VERSION_ID === 80020) {
$this->markTestSkipped('Skip bugged PHP version: https://github.com/php/php-src/issues/8827');
}

Expand Down Expand Up @@ -750,7 +750,7 @@ public function testKeepsRunningEvenWhenAllStdioPipesHaveBeenClosed()
*/
public function testKeepsRunningEvenWhenAllStdioSocketsHaveBeenClosed()
{
if (PHP_VERSION_ID === 80107 || PHP_VERSION_ID === 80020) {
if (PHP_VERSION_ID === 80108 || PHP_VERSION_ID === 80107 || PHP_VERSION_ID === 80020) {
$this->markTestSkipped('Skip bugged PHP version: https://github.com/php/php-src/issues/8827');
}

Expand Down

0 comments on commit 1c46b3b

Please sign in to comment.