Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): remove leading dollar sign #51

Merged
merged 1 commit into from Jun 24, 2022
Merged

chore(docs): remove leading dollar sign #51

merged 1 commit into from Jun 24, 2022

Conversation

nhedger
Copy link
Contributor

@nhedger nhedger commented Jun 20, 2022

@nhedger nhedger mentioned this pull request Jun 20, 2022
Merged
clue
clue reviewed Jun 20, 2022
View reviewed changes
Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nhedger Thank you!

Can you apply/squash this minor suggestion? Once this is in, we should also apply the same changes to the 3.x and 2.x branches 👍

README.md Outdated Show resolved Hide resolved
@clue clue added this to the v4.0.0 milestone Jun 20, 2022
@clue clue requested a review from WyriHaximus June 20, 2022 14:53
clue
clue approved these changes Jun 20, 2022
View reviewed changes
Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nhedger Thanks for the quick update, changes LGTM! 👍

@WyriHaximus WyriHaximus merged commit 8f4251c into reactphp:4.x Jun 24, 2022
@nhedger nhedger deleted the chore/remove-leading-dollar branch June 24, 2022 09:57
@clue
Copy link
Member

clue commented Jun 27, 2022

@nhedger Glad this has been merged! Can you also apply the same changes to the 3.x and 2.x branches? 👍

This was referenced Jun 28, 2022
Merged
Merged
@nhedger
Copy link
Contributor Author

nhedger commented Jun 28, 2022

@clue, see #52 and #53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WyriHaximus WyriHaximus WyriHaximus approved these changes

@clue clue clue approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nhedger @clue @WyriHaximus