Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor UriEndpoint #2700

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor UriEndpoint #2700

wants to merge 1 commit into from

Commits on May 16, 2023

  1. Refactor UriEndpoint (reactor#2700) 

    Clean up UriEndpoint logic to be based around the java.net.URI. Move relevant methods into this class. Construct instances using static method. Only calculate derived values on demand (e.g. toExternalForm) when needed in the various request implementations. Cleaned up redirection logic. Added additional tests. Made conversion from InetSocketAddress more efficient (removed the substrings which trimmed out the ports). Fixed HttpClientTest to support ipv6 (by using NetUtil.toSocketAddressString to get the [] around the address, and also fixed FailedHttpClientRequest.uri() from returning full URI rather than just Netty definition of "uri" which is raw path and query. Fixed ClientTransportTest to support ipv6.

Fixes reactor#829
    @yuzawa-san
    yuzawa-san committed May 16, 2023
    Configuration menu
    Copy the full SHA
    00f28cc View commit details
    Browse the repository at this point in the history