Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deregister connection pool metrics from Micrometer (or alternate registry) when disposing the connection pool #2608

Merged
merged 4 commits into from Dec 12, 2022
Merged

Deregister connection pool metrics from Micrometer (or alternate registry) when disposing the connection pool #2608

merged 4 commits into from Dec 12, 2022

Commits on Dec 9, 2022

  1. Deregister pool metrics from Micrometer (or alternate registry) in or… 

    …der to

release resources when there is a large churn of connection pools and endpoints.
    @manolama
    manolama committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    8a2cf35 View commit details
    Browse the repository at this point in the history

  2. Address code review. Provide a default deRegister implementation to a… 

    …void interface

changes for now. Remove unecessary Connection return from the unit metrics unit test.
Thanks @violetagg
    @manolama
    manolama committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    9138d34 View commit details
    Browse the repository at this point in the history

  3. Fix the testConnectionPoolPendingAcquireSize test to detect deregis… 

    …tration

of the pool metrics after disposal.
    @manolama
    manolama committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    e58a81c View commit details
    Browse the repository at this point in the history

  4. Restore new line at the end of ConnectionProviderTest.java

    @manolama
    manolama committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    6e7f5f7 View commit details
    Browse the repository at this point in the history