New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re enable HttpMetricsHandlerTests in netty5 branch #2337
Re enable HttpMetricsHandlerTests in netty5 branch #2337
Conversation
please do not review for the moment, some tests are failing. |
reactor-netty-http/src/main/java/reactor/netty/http/client/HttpTrafficHandler.java
Outdated
Show resolved
Hide resolved
reactor-netty-http/src/test/java/reactor/netty/http/HttpMetricsHandlerTests.java
Outdated
Show resolved
Hide resolved
reactor-netty-http/src/test/java/reactor/netty/http/HttpMetricsHandlerTests.java
Outdated
Show resolved
Hide resolved
reactor-netty-http/src/test/java/reactor/netty/http/HttpMetricsHandlerTests.java
Outdated
Show resolved
Hide resolved
reactor-netty-http/src/test/java/reactor/netty/http/HttpMetricsHandlerTests.java
Outdated
Show resolved
Hide resolved
reactor-netty-http/src/test/java/reactor/netty/http/HttpMetricsHandlerTests.java
Outdated
Show resolved
Hide resolved
reactor-netty-http/src/test/java/reactor/netty/http/HttpMetricsHandlerTests.java
Outdated
Show resolved
Hide resolved
reactor-netty-http/src/test/java/reactor/netty/http/HttpMetricsHandlerTests.java
Outdated
Show resolved
Hide resolved
reactor-netty-http/src/test/java/reactor/netty/http/HttpMetricsHandlerTests.java
Outdated
Show resolved
Hide resolved
reactor-netty-http/src/test/java/reactor/netty/http/HttpMetricsHandlerTests.java
Outdated
Show resolved
Hide resolved
I have temporarily disabled the testRecordingFailsClientSide and testRecordingFailsClientSide tests, and now, we have successful tests for both ubuntu and macos. So, I tend to think that some more works need to be done for the other #2335 PR, which is most likely to be again related (because if I disable the testRecordingFailsClientSide and the testRecordingFailsClientSide, then tests are passing OK). Now, the remaining failing test is the same one for windows from the #2338. let's not merge this PR for the moment, I need to get back to the other #2335. |
...tor-netty-http/src/main/java/reactor/netty/http/client/AbstractHttpClientMetricsHandler.java
Outdated
Show resolved
Hide resolved
...tor-netty-http/src/main/java/reactor/netty/http/server/AbstractHttpServerMetricsHandler.java
Outdated
Show resolved
Hide resolved
…oops queue. this means we should ensure that all event loops are idle before testing metrics
…s that all event loops are idles
Related to #1873
This PR is an attempt to bring back the HttpMetricsHandlerTests into netty5 branch.
mainly, here what has been done: