Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make use of CompletionStage#handle instead of whenComplete #3221

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Make use of CompletionStage#handle instead of whenComplete #3221

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions reactor-core/src/main/java/reactor/core/publisher/MonoCompletionStage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public void cancel() {
return;
}

future.whenComplete((v, e) -> {
future.handle((v, e) -> {
if (sds.isCancelled()) {
//nobody is interested in the Mono anymore, don't risk dropping errors
Context ctx = sds.currentContext();
Expand All @@ -79,7 +79,7 @@ public void cancel() {
Operators.onDiscard(v, ctx);
}

return;
return null;
}
try {
if (e instanceof CompletionException) {
Expand All @@ -99,6 +99,7 @@ else if (v != null) {
Operators.onErrorDropped(e1, actual.currentContext());
throw Exceptions.bubble(e1);
}
return null;
});
}

Expand Down