Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a Many sink / EmitterProcessor subscriber disposal leak #3029

Merged
merged 1 commit into from
Apr 21, 2022
Merged

Fix a Many sink / EmitterProcessor subscriber disposal leak #3029

merged 1 commit into from
Apr 21, 2022

Commits on Apr 21, 2022

  1. Fix a Many sink / EmitterProcessor subscriber disposal leak 

    The EmitterProcessor#remove method causes retaining of subscribers if
the removal is done in parallel, as the CAS failure doesn't cause a
new loop iteration.

This applies to direct instantiations of EmitterProcessor as well as
Sinks.many().onBackpressureBuffer sinks.

This commit fixes the method to loop back when the CAS fails.

Fixes #3028.
    @simonbasle
    simonbasle committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    d104259 View commit details
    Browse the repository at this point in the history