-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent unnecessary duplicated lines in backtraces #2780
Merged
Merged
Commits on Sep 21, 2021
-
Prevent unnecessary duplicated lines in backtraces
This commit removes the `i` counter that was effectively guaranteeing duplicated entries in the backtrace (eg. with a checkpoint) in the case where the triggering exception was reused. The only differentiator was then the indentation (driven by `i`). This is especially visible when using a `checkpoint(String)` operator along a `retry`. Provided the same exception instance is emitted on each retry loop, `checkpoint` will add to the backtrace on each loop. This commit removes the `i` from the tracking of existing backtraces and thus ensures that for the same parent subscriber, prefix and description there will be only one entry in the backtrace. Fixes #2774.
Configuration menu - View commit details
-
Copy full SHA for 4c8109b - Browse repository at this point
Copy the full SHA 4c8109bView commit details
Commits on Sep 22, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 87afc2d - Browse repository at this point
Copy the full SHA 87afc2dView commit details -
Configuration menu - View commit details
-
Copy full SHA for b40ef10 - Browse repository at this point
Copy the full SHA b40ef10View commit details -
Configuration menu - View commit details
-
Copy full SHA for 562cd8a - Browse repository at this point
Copy the full SHA 562cd8aView commit details -
Configuration menu - View commit details
-
Copy full SHA for bed9cb0 - Browse repository at this point
Copy the full SHA bed9cb0View commit details
Commits on Sep 23, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 758dbd1 - Browse repository at this point
Copy the full SHA 758dbd1View commit details -
Configuration menu - View commit details
-
Copy full SHA for d5b0643 - Browse repository at this point
Copy the full SHA d5b0643View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ac4f06 - Browse repository at this point
Copy the full SHA 7ac4f06View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b17d86 - Browse repository at this point
Copy the full SHA 2b17d86View commit details -
Configuration menu - View commit details
-
Copy full SHA for f42be5b - Browse repository at this point
Copy the full SHA f42be5bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.