Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent unnecessary duplicated lines in backtraces #2780

Merged
merged 10 commits into from
Oct 1, 2021

Commits on Sep 21, 2021

  1. Prevent unnecessary duplicated lines in backtraces

    This commit removes the `i` counter that was effectively guaranteeing
    duplicated entries in the backtrace (eg. with a checkpoint) in the case
    where the triggering exception was reused. The only differentiator was
    then the indentation (driven by `i`).
    
    This is especially visible when using a `checkpoint(String)` operator
    along a `retry`. Provided the same exception instance is emitted on each
    retry loop, `checkpoint` will add to the backtrace on each loop.
    
    This commit removes the `i` from the tracking of existing backtraces and
    thus ensures that for the same parent subscriber, prefix and description
    there will be only one entry in the backtrace.
    
    Fixes #2774.
    simonbasle committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    4c8109b View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2021

  1. Configuration menu
    Copy the full SHA
    87afc2d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b40ef10 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    562cd8a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    bed9cb0 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2021

  1. Configuration menu
    Copy the full SHA
    758dbd1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d5b0643 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7ac4f06 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2b17d86 View commit details
    Browse the repository at this point in the history
  5. Fix ReactorDebugAgentTest

    simonbasle committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    f42be5b View commit details
    Browse the repository at this point in the history