fix #2186 Align MonoCollect and MonoCollectList #2193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 3.2.x #2193 +/- ##
============================================
+ Coverage 84.91% 84.95% +0.03%
- Complexity 4014 4015 +1
============================================
Files 364 364
Lines 30488 30509 +21
Branches 5667 5671 +4
============================================
+ Hits 25889 25919 +30
+ Misses 3002 2997 -5
+ Partials 1597 1593 -4 Continue to review full report at Codecov.
|
This change aligns the implementation of MonoCollect to be comparable to MonoList. Effectively they're the same, a MonoList is but a MonoCollect with an ArrayList as the container. Fix reactor#2186
rstoyanchev
force-pushed
the
2186-monoCollect
branch
from
3e6aea3
to
85feec9
Compare
simonbasle
approved these changes
Jun 16, 2020
simonbasle
changed the title
|
@simonbasle this PR seems to have been merged on a maintenance branch, please ensure the change is merge-forwarded to intermediate maintenance branches and up to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change aligns the implementation of
MonoCollectto be directly comparable to that ofMonoListin order to address #2186.MonoListseems better protected against competing upstream and downstream signals and the two should not be different as far as I can see. AMonoListis essentially aMonoCollectwith anArrayListas the container.