Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: translated home page #909

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

Zukhrik
Copy link

@Zukhrik Zukhrik commented Aug 10, 2023

Перевод главной страницы

@Zukhrik
Copy link
Author

Zukhrik commented Aug 11, 2023

@slorber could you check PR?

@slorber
Copy link
Contributor

slorber commented Aug 11, 2023

I'm not the manager of this repo and don't speak russian, I can't do anything for you sorry 😅

Copy link

@AbdullahWins AbdullahWins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done!

@Zukhrik
Copy link
Author

Zukhrik commented Sep 4, 2023

@titovmx Привет. Можешь чекнуть ПР?

Copy link
Collaborator

@titovmx titovmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

привет! оставил свои предложения

src/components/Layout/HomeContent.js Outdated Show resolved Hide resolved
src/components/Layout/HomeContent.js Outdated Show resolved Hide resolved
src/components/Layout/HomeContent.js Outdated Show resolved Hide resolved
src/components/Layout/HomeContent.js Outdated Show resolved Hide resolved
src/components/Layout/HomeContent.js Outdated Show resolved Hide resolved
src/components/Layout/HomeContent.js Outdated Show resolved Hide resolved
src/components/Layout/HomeContent.js Outdated Show resolved Hide resolved
src/components/Layout/HomeContent.js Outdated Show resolved Hide resolved
src/components/Layout/HomeContent.js Outdated Show resolved Hide resolved
src/components/Layout/HomeContent.js Outdated Show resolved Hide resolved
@titovmx
Copy link
Collaborator

titovmx commented Sep 8, 2023

ещё я думаю, что не нужно пушить файлы idea в репу, так как переводчики могут пользоваться разными инструментами

@titovmx
Copy link
Collaborator

titovmx commented Sep 8, 2023

@Zukhrik спасибо за перевод!
а почему выбрали эту страницу? она просто не была указана на странице с прогрессом, и я, честно, не знаю почему :)

@Zukhrik
Copy link
Author

Zukhrik commented Sep 18, 2023

@titovmx когда посетил ру.реакт.дев увидел что главная страница не переведена на русский и сразу же начал переводить. После создание ПРа узнаю что надо писать в странице с переводом. Я думал ПР так и будет висеть и ни кто не чекнит.

Спасибо за ревью Максим. Скоро апдейтну ПР

@Zukhrik
Copy link
Author

Zukhrik commented Sep 29, 2023

Здравствуйте @titovmx. Можете еще раз чекнуть ПР?

@titovmx
Copy link
Collaborator

titovmx commented Sep 29, 2023

@Zukhrik спасибо за вклад в перевод и правки! я посмотрю в ближайшие дни

Copy link
Collaborator

@titovmx titovmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

спасибо за обновления!
заметил, что несколько проблем осталось

src/components/Layout/HomeContent.js Outdated Show resolved Hide resolved
src/components/Layout/HomeContent.js Outdated Show resolved Hide resolved
src/components/Layout/HomeContent.js Outdated Show resolved Hide resolved
src/components/Layout/HomeContent.js Outdated Show resolved Hide resolved
src/components/Layout/HomeContent.js Outdated Show resolved Hide resolved
src/components/Layout/HomeContent.js Outdated Show resolved Hide resolved
src/content/community/conferences.md Outdated Show resolved Hide resolved
@Zukhrik
Copy link
Author

Zukhrik commented Oct 27, 2023

@titovmx Прошу чекнуть ПР еще раз. Спасибо за ревью 😊

Copy link
Collaborator

@titovmx titovmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Спасибо за вклад!
LGTM now

Copy link

github-actions bot commented Nov 6, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 78.95 KB (🟡 +1.56 KB) 182.69 KB
/500 78.94 KB (🟡 +1.56 KB) 182.69 KB
/[[...markdownPath]] 80.54 KB (🟡 +1.56 KB) 184.28 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@Zukhrik
Copy link
Author

Zukhrik commented Nov 29, 2023

@titovmx Здравствуйте хотелось узнать когда ПР будет в продакшине.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants