Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs about an existence of .elementType #2145

Merged
merged 1 commit into from Jul 13, 2019

Conversation

lonyele
Copy link
Contributor

@lonyele lonyele commented Jul 13, 2019

Hi, I've met the same issue on here at storybook and found the following PR that adds the elementType feature. Doc can be found on npm, but not on the official react site.

Hi, I've met the same issue on [here](facebook/prop-types#200) at storybook and found the following [PR](facebook/prop-types#211) that adds the `elementType` feature. It could find the doc on npm, but not the official react site.
@facebook-github-bot
Copy link
Collaborator

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@reactjs-bot
Copy link

Deploy preview for reactjs ready!

Built with commit b63d27a

https://deploy-preview-2145--reactjs.netlify.com

@facebook-github-bot
Copy link
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@lex111 lex111 merged commit dc650ec into reactjs:master Jul 13, 2019
@lex111
Copy link
Member

lex111 commented Jul 13, 2019

@lonyele thank you!

@lonyele lonyele deleted the patch-1 branch July 20, 2019 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants