Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to GitHub Actions for testing #1198

Merged
merged 6 commits into from Sep 16, 2022
Merged

Switch to GitHub Actions for testing #1198

merged 6 commits into from Sep 16, 2022

Conversation

hibachrach
Copy link
Contributor

@hibachrach hibachrach commented Aug 26, 2022 •
edited

Converts from Travis to GH actions. Fixes #1193

@hibachrach hibachrach force-pushed the switch-to-github-actions branch 3 times, most recently from c9c7d20 to efbf304 Compare August 26, 2022 05:30
@hibachrach hibachrach changed the title TEMP Switch to GitHub Actions for testing Switch to GitHub Actions for testing Aug 26, 2022
@hibachrach
Copy link
Contributor Author

Ah I think #1150 broke some of the tests a bit more. The new version of webpack-dev-server has a bug because of an undeclared dependency (webpack/webpack-dev-server#2396) and changed the peer dependency support to be webpack@^4.0.0. Not sure how to proceed

@hibachrach
Copy link
Contributor Author

I do think we ought to revisit the supported versions of Webpacker with this gem. I'm generally new to this sort of thing so unsure of where to cut things off (especially considering non-Shakapacker Webpacker is already retired).

@hibachrach hibachrach mentioned this pull request Aug 30, 2022
Merged
@justin808 justin808 mentioned this pull request Aug 30, 2022
Closed
@justin808
Copy link
Collaborator

@HarrisonB I agree with you. I opened an issue for this: #1199.

@justin808
Copy link
Collaborator

justin808 commented Sep 9, 2022 •
edited

@HarrisonB any update? I mentioned that we can revert the new webpack-dev-server until we get CI running.

@hibachrach hibachrach mentioned this pull request Sep 10, 2022
Merged
@hibachrach hibachrach force-pushed the switch-to-github-actions branch 2 times, most recently from ee464a1 to 3f0f44a Compare September 12, 2022 01:32
@hibachrach
Switch to GitHub Actions for testing
eca3e8d 
See here for an argument as to why to do so
@hibachrach
Update rails past 5.2.5 to work around yanked mimemagic
255f82f 
See these links for context:
* rails/rails#41750
* https://rubyonrails.org/2021/3/26/marcel-upgrade-releases
@hibachrach
Fix Minitest handling of kwargs after update past 5.16.0
f85685d 
Issue was introduced in

minitest/minitest@6fecff9

and hack workaround was introduced in

minitest/minitest@b8ddc4f

I *think* that changing the API make this work w/o the workaround would
require a breaking change so we can leave that for later.
@hibachrach
Drop end-of-life Ruby 2.5 from testing matrix
dd2e249 
This was EOLed over a year ago and doing a `bundle install` with the
current set of packages gives

> minitest-5.16.3 requires ruby version < 4.0, >= 2.6, which is
> incompatible with the current version
@hibachrach
Upgrade JRuby to 9.3 within testing matrix
5f6062d 
Unfortunately Bundler 2 and JRuby 9.1 are not compatible on GitHub
actions (see here: ruby/setup-ruby#108) which
leads to failures.

Additionally, due to the `webdrivers` gem as a testing dependency
needing upgrading, 9.2 is also a no-go.

JRuby 9.3 matches (MRI) Ruby 2.6 which we just made the floor of the testing
matrix, so this is likely a good version to match anyhow.
@justin808
Copy link
Collaborator

@HarrisonB let me know when to review.

@hibachrach hibachrach marked this pull request as ready for review September 14, 2022 20:51
@hibachrach
Copy link
Contributor Author

@justin808 It's now ready for review

justin808
justin808 approved these changes Sep 16, 2022
View reviewed changes
Copy link
Collaborator

@justin808 justin808 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justin808 justin808 merged commit f873861 into reactjs:master Sep 16, 2022
@justin808
Copy link
Collaborator

Thanks, @hibachrach. Let's see if this runs! We might need some followups.

@justin808
Copy link
Collaborator

Looks like it's running: https://github.com/reactjs/react-rails/actions

@hibachrach hibachrach deleted the switch-to-github-actions branch September 17, 2022 00:23
hibachrach added a commit to hibachrach/react-rails that referenced this pull request Sep 17, 2022
@hibachrach
Update status bage to point to GitHub Actions
e3c13cf 
See reactjs#1198
@hibachrach hibachrach mentioned this pull request Sep 17, 2022
Merged
@ahangarha ahangarha mentioned this pull request Nov 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justin808 justin808 justin808 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert from Travis to Github Actions
2 participants
@hibachrach @justin808