Ignore private class properties (#347)

reactjs · May 3, 2019 · a0824f0 · a0824f0
1 parent 2fd59a6
commit a0824f0
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 0 deletions.
diff --git a/src/utils/__tests__/getClassMemberValuePath-test.js b/src/utils/__tests__/getClassMemberValuePath-test.js
@@ -94,4 +94,29 @@ describe('getClassMemberValuePath', () => {
       );
     });
   });
+
+  describe('PrivateClassProperty', () => {
+    it('ignores private class properties', () => {
+      const def = statement(`
+        class Foo {
+          #foo = 42;
+        }
+      `);
+
+      expect(getClassMemberValuePath(def, 'foo')).toBe(undefined);
+    });
+
+    it('finds "normal" class properties with private present', () => {
+      const def = statement(`
+        class Foo {
+          #private = 54;
+          foo = 42;
+        }
+      `);
+
+      expect(getClassMemberValuePath(def, 'foo')).toBe(
+        def.get('body', 'body', 1, 'value'),
+      );
+    });
+  });
 });
diff --git a/src/utils/getClassMemberValuePath.js b/src/utils/getClassMemberValuePath.js
@@ -30,6 +30,7 @@ export default function getClassMemberValuePath(
       memberPath =>
         (!memberPath.node.computed ||
           types.Literal.check(memberPath.node.key)) &&
+        !types.PrivateName.check(memberPath.node.key) &&
         getNameOrValue(memberPath.get('key')) === memberName &&
         memberPath.node.kind !== 'set',
     )