fix: finalize behaves well with useDeprecatedSynchronousErrorHandling #6251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds tests and ensures a few more scenarios that were hit in Google because they use the deprecated synchronous error handling. fixes ReactiveX#6250
Just for readability. The deprecated stuff is a hot mess, and this shows what we get to delete in version 8 more cleanly.
benlesh
commented
Apr 22, 2021
|
|
||
| subscriber.add( |
There was a problem hiding this comment.
I split this up, and added comments. Just for organizational reasons more than anything.
benlesh
commented
Apr 22, 2021
| // properly decorate the subscriber with `__syncError`. | ||
| subscriber.add(operator.call(subscriber, this.source)); | ||
| } else { | ||
| try { |
There was a problem hiding this comment.
the primary "fix" is here for the cases where teardown wasn't being called after it was registered if a sync error was thrown.
benlesh
commented
Apr 22, 2021
| subscriber.add(callback); | ||
| // TODO: This try/finally was only added for `useDeprecatedSynchronousErrorHandling`. | ||
| // REMOVE THIS WHEN THAT HOT GARBAGE IS REMOVED IN V8. | ||
| try { |
There was a problem hiding this comment.
The "fix" for the finalize issue in the sync case is here. Note that adding a callback to a closed subscriber will cause it to be executed immediately.
|
Do we have tests that are the equivalent of these but are for the normal error handling - not the deprecated synchronous error handling? Seems like something worth testing if we're not already doing that. |
|
@cartant I'm unsure. I'll have a look after I merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests and ensures a few more scenarios that were hit in Google because they use the deprecated synchronous error handling.
fixes #6250
cc @leggechr