Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: finalize behaves well with useDeprecatedSynchronousErrorHandling #6251

Merged
merged 4 commits into from Apr 23, 2021
Merged

fix: finalize behaves well with useDeprecatedSynchronousErrorHandling #6251

merged 4 commits into from Apr 23, 2021

Commits on Apr 22, 2021

  1. fix: finalize behaves well with useDeprecatedSynchronousErrorHandling 

    Adds tests and ensures a few more scenarios that were hit in Google because they use the deprecated synchronous error handling.

fixes ReactiveX#6250
    @benlesh
    benlesh committed Apr 22, 2021
    Copy the full SHA
    0f3f53a View commit details
    Browse the repository at this point in the history

  2. refactor: Move deprecated junk to its own method 

    Just for readability. The deprecated stuff is a hot mess, and this shows what we get to delete in version 8 more cleanly.
    @benlesh
    benlesh committed Apr 22, 2021
    Copy the full SHA
    729ea95 View commit details
    Browse the repository at this point in the history

  3. refactor: Add more comments

    @benlesh
    benlesh committed Apr 22, 2021
    Copy the full SHA
    d0fca8d View commit details
    Browse the repository at this point in the history

  4. test: Add more tests around gross mode and finalize

    @benlesh
    benlesh committed Apr 22, 2021
    Copy the full SHA
    dcb9543 View commit details
    Browse the repository at this point in the history