fix: Do not run reducer on non-optimistic fetches #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +141 B (0%) Total Size: 29.4 kB
ℹ️ View Unchanged
|
ntucker
force-pushed
the
fix/update-in-render
branch
from
be1abcd
to
d9065d8
Compare
ntucker
commented
Mar 21, 2020
| @@ -20,9 +20,7 @@ export default function useError< | |||
| if (!meta.error) { | |||
| // this means we probably deleted the entity found in this result | |||
| const err: any = new Error( | |||
| `Resource not found in cache ${ | |||
| params ? fetchShape.getFetchKey(params) : '' | |||
There was a problem hiding this comment.
this was actually not needed - as params is already discriminated above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #300 .
Motivation
Even though the state does not update, React will warn about the reducer running from render (triggered from useRetrieve()). Although React should short-circuit and not actually re-render, it doesn't harm for us to short-circuit even earlier - after all it will run less code!
Solution
Intercept all fetch dispatches in the NetworkManager that cannot cause state updates. (No optimistic response)