-
-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat!] Get lineProps, lineNumberProps, and lineNumberContainerProps back #320
base: master
Are you sure you want to change the base?
[feat!] Get lineProps, lineNumberProps, and lineNumberContainerProps back #320
Conversation
Hey @simmerer. I got a rough version of what it would look like to bring back the missed props. Would need some help or guidance on how to fix the snapshots. Do you regenerate them from scratch? Also, have a look at the code and let me know if you find something weird or incorrect. Thanks! |
@@ -20,6 +20,7 @@ exports[`SyntaxHighlighter component passes along code style to non-inline line | |||
} | |||
} | |||
> | |||
<<<<<<< HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be done.
@@ -3304,66 +3304,106 @@ exports[`SyntaxHighlighter component renders line numbers if showLineNumbers === | |||
1 | |||
</span> | |||
<span | |||
<<<<<<< HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be done.
@fmvilas If I'm confident that rendering changes are correct and the snapshots need to be updated, then I run I'll take a look soon. Thanks for starting on this! |
I'm getting this bug right now:
Does this pull request to solve it? |
@SalahAdDin I see that this PR has a few merge conflicts, and now that we've introduced the |
@simmerer Any progress about this? Thanks. |
@fmvilas what happened whit thi one? |
Sorry got completely neck deep into AsyncAPI work. Don't have time to contribute to this one so feel free to take over it or close it. |
lineNumberContainerProps
.Fixes #311