-
-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does not work with TailwindCSS anymore #311
Labels
Comments
Good catch! Looks like there was a PR to get rid of If you've got a bit of time to implement a solution, we'd be grateful. |
Absolutely. Do you want me to cherry pick the changes on #229? |
Go for it! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
We're using TailwindCSS to style our website. Just upgraded this component for security reasons and found that
lineNumberContainerProps
andlineNumberProps
were removed. Also,lineProps
is not allowing us to pass custom classNames. That makes it impossible for us to use both Tailwind and this component.You can see more here: https://github.com/asyncapi/website/blob/master/components/editor/CodeBlock.js#L61-L77.
Describe the solution you'd like
For
lineNumberProps
andlineNumberContainerProps
either bring them back or maybe create something likelineNumberClassNames
andlineNumberContainerClassNames
. Happy to discuss what's better.For
lineProps
, it seems the offending line is this one. Maybe this can be changed to:Describe alternatives you've considered
I've considered requiring the Tailwind configuration file from the component but that would couple the component to the config file, making it less reusable. Also considered hard-coding the values I want as inline styles but we'd get duplicated values in the config file and in this component.
Happy to help implementing the solution to this. Thanks for the great work! 🙌
The text was updated successfully, but these errors were encountered: