Skip to content

Commit

Permalink
chore: drop material-bottom-tabs package
Browse files Browse the repository at this point in the history
BREAKING CHANGE: the navigator should be imported from 'react-native-paper/react-navigation' instead when it's available
  • Loading branch information
satya164 committed Feb 17, 2023
1 parent fec72a7 commit 4362457
Show file tree
Hide file tree
Showing 25 changed files with 24 additions and 1,590 deletions.
1 change: 0 additions & 1 deletion .eslintrc.json
Expand Up @@ -14,7 +14,6 @@
"@react-navigation/drawer",
"@react-navigation/bottom-tabs",
"@react-navigation/material-top-tabs",
"@react-navigation/material-bottom-tabs",
"@react-navigation/elements",
"@react-navigation/devtools",
"react-native-drawer-layout",
Expand Down
2 changes: 0 additions & 2 deletions .github/ISSUE_TEMPLATE/bug-report.yml
Expand Up @@ -67,7 +67,6 @@ body:
options:
- label: '@react-navigation/bottom-tabs'
- label: '@react-navigation/drawer'
- label: '@react-navigation/material-bottom-tabs'
- label: '@react-navigation/material-top-tabs'
- label: '@react-navigation/stack'
- label: '@react-navigation/native-stack'
Expand All @@ -87,7 +86,6 @@ body:
| @react-navigation/native |
| @react-navigation/bottom-tabs |
| @react-navigation/drawer |
| @react-navigation/material-bottom-tabs |
| @react-navigation/material-top-tabs |
| @react-navigation/stack |
| @react-navigation/native-stack |
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/check-labels.yml
Expand Up @@ -23,7 +23,6 @@ jobs:
[
'bottom-tabs',
'drawer',
'material-bottom-tabs',
'material-top-tabs',
'stack',
'native-stack',
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/versions.yml
Expand Up @@ -21,7 +21,6 @@ jobs:
@react-navigation/core
@react-navigation/devtools
@react-navigation/drawer
@react-navigation/material-bottom-tabs
@react-navigation/material-top-tabs
@react-navigation/routers
@react-navigation/stack
Expand Down
1 change: 0 additions & 1 deletion README.md
Expand Up @@ -19,7 +19,6 @@ If you are looking for version 4, the code can be found in the [4.x branch](http
| [@react-navigation/devtools](/packages/devtools) | [![badge](https://img.shields.io/npm/v/@react-navigation/devtools.svg)](https://www.npmjs.com/package/@react-navigation/devtools) |
| [@react-navigation/drawer](/packages/drawer) | [![badge](https://img.shields.io/npm/v/@react-navigation/drawer.svg)](https://www.npmjs.com/package/@react-navigation/drawer) |
| [@react-navigation/elements](/packages/elements) | [![badge](https://img.shields.io/npm/v/@react-navigation/elements.svg)](https://www.npmjs.com/package/@react-navigation/elements) |
| [@react-navigation/material-bottom-tabs](/packages/material-bottom-tabs) | [![badge](https://img.shields.io/npm/v/@react-navigation/material-bottom-tabs.svg)](https://www.npmjs.com/package/@react-navigation/material-bottom-tabs) |
| [@react-navigation/material-top-tabs](/packages/material-top-tabs) | [![badge](https://img.shields.io/npm/v/@react-navigation/material-top-tabs.svg)](https://www.npmjs.com/package/@react-navigation/material-top-tabs) |
| [@react-navigation/native-stack](/packages/native-stack) | [![badge](https://img.shields.io/npm/v/@react-navigation/stack.svg)](https://www.npmjs.com/package/@react-navigation/native-stack) |
| [@react-navigation/native](/packages/native) | [![badge](https://img.shields.io/npm/v/@react-navigation/native.svg)](https://www.npmjs.com/package/@react-navigation/native) |
Expand Down
1 change: 0 additions & 1 deletion example/package.json
Expand Up @@ -34,7 +34,6 @@
"react-native-reanimated": "~2.9.1",
"react-native-safe-area-context": "4.4.1",
"react-native-screens": "~3.18.0",
"react-native-vector-icons": "^9.1.0",
"react-native-web": "~0.18.7"
},
"devDependencies": {
Expand Down
4 changes: 2 additions & 2 deletions example/src/Screens/BottomTabs.tsx
@@ -1,3 +1,4 @@
import MaterialCommunityIcons from '@expo/vector-icons/MaterialCommunityIcons';
import {
createBottomTabNavigator,
useBottomTabBarHeight,
Expand All @@ -13,15 +14,14 @@ import type { StackScreenProps } from '@react-navigation/stack';
import { BlurView } from 'expo-blur';
import * as React from 'react';
import { ScrollView, StatusBar, StyleSheet } from 'react-native';
import MaterialCommunityIcons from 'react-native-vector-icons/MaterialCommunityIcons';

import Albums from '../Shared/Albums';
import Chat from '../Shared/Chat';
import Contacts from '../Shared/Contacts';
import SimpleStackScreen, { SimpleStackParams } from './SimpleStack';

const getTabBarIcon =
(name: string) =>
(name: React.ComponentProps<typeof MaterialCommunityIcons>['name']) =>
({ color, size }: { color: string; size: number }) =>
<MaterialCommunityIcons name={name} color={color} size={size} />;

Expand Down
2 changes: 1 addition & 1 deletion example/src/Screens/DynamicTabs.tsx
@@ -1,8 +1,8 @@
import Feather from '@expo/vector-icons/Feather';
import { createBottomTabNavigator } from '@react-navigation/bottom-tabs';
import * as React from 'react';
import { StyleSheet, View } from 'react-native';
import { Button, Title } from 'react-native-paper';
import Feather from 'react-native-vector-icons/Feather';

type BottomTabParams = {
[key: string]: undefined;
Expand Down
75 changes: 0 additions & 75 deletions example/src/Screens/MaterialBottomTabs.tsx

This file was deleted.

2 changes: 1 addition & 1 deletion example/src/Screens/StackHeaderCustomization.tsx
@@ -1,3 +1,4 @@
import MaterialCommunityIcons from '@expo/vector-icons/MaterialCommunityIcons';
import { HeaderBackground, useHeaderHeight } from '@react-navigation/elements';
import { ParamListBase, useTheme } from '@react-navigation/native';
import {
Expand All @@ -16,7 +17,6 @@ import {
View,
} from 'react-native';
import { Appbar, Button } from 'react-native-paper';
import MaterialCommunityIcons from 'react-native-vector-icons/MaterialCommunityIcons';

import Albums from '../Shared/Albums';
import Article from '../Shared/Article';
Expand Down
2 changes: 1 addition & 1 deletion example/src/index.tsx
@@ -1,3 +1,4 @@
import MaterialIcons from '@expo/vector-icons/MaterialIcons';
import AsyncStorage from '@react-native-async-storage/async-storage';
import { useReduxDevToolsExtension } from '@react-navigation/devtools';
import {
Expand Down Expand Up @@ -38,7 +39,6 @@ import {
Provider as PaperProvider,
} from 'react-native-paper';
import { SafeAreaView } from 'react-native-safe-area-context';
import MaterialIcons from 'react-native-vector-icons/MaterialIcons';

import { restartApp } from './Restart';
import { RootDrawerParamList, RootStackParamList, SCREENS } from './screens';
Expand Down
5 changes: 0 additions & 5 deletions example/src/screens.tsx
Expand Up @@ -6,7 +6,6 @@ import DrawerView from './Screens/DrawerView';
import DynamicTabs from './Screens/DynamicTabs';
import LinkComponent from './Screens/LinkComponent';
import MasterDetail from './Screens/MasterDetail';
import MaterialBottomTabs from './Screens/MaterialBottomTabs';
import MaterialTopTabsScreen from './Screens/MaterialTopTabs';
import MixedHeaderMode from './Screens/MixedHeaderMode';
import MixedStack from './Screens/MixedStack';
Expand Down Expand Up @@ -70,10 +69,6 @@ export const SCREENS = {
title: 'Material Top Tabs',
component: MaterialTopTabsScreen,
},
MaterialBottomTabs: {
title: 'Material Bottom Tabs',
component: MaterialBottomTabs,
},
DynamicTabs: {
title: 'Dynamic Tabs',
component: DynamicTabs,
Expand Down
1 change: 0 additions & 1 deletion example/tsconfig.json
Expand Up @@ -6,7 +6,6 @@
{ "path": "../packages/devtools" },
{ "path": "../packages/drawer" },
{ "path": "../packages/elements" },
{ "path": "../packages/material-bottom-tabs" },
{ "path": "../packages/material-top-tabs" },
{ "path": "../packages/native" },
{ "path": "../packages/native-stack" },
Expand Down

0 comments on commit 4362457

Please sign in to comment.