Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iOS): replace nullish coalescing operator for older iOS versions #3388

Conversation

kowoohyuk
Copy link
Contributor

During my recent work with react-native-webview, I encountered an issue with the postMessage function not functioning correctly on older iOS devices, notably iOS 13.7.
Upon investigation, it became apparent that this issue stems from the WKUserScript initialization code changed in react-native-webview 13.8 (#3157)

Considering that iOS versions 13.7 and below do not support the Nullish coalescing assignment (??=) operator, I propose exploring alternatives to this operator for compatibility purposes.
Your review and feedback on this matter would be greatly appreciated.

Thank you!

@kowoohyuk kowoohyuk changed the title fix(iOS): unsupported nullish coalescing operator for older iOS versions fix(iOS): replace nullish coalescing operator for older iOS versions Apr 9, 2024
@TheAlmightyBob TheAlmightyBob force-pushed the fix-ios-nullish-coalescing-operator-support branch from daf3eba to 9979a98 Compare April 19, 2024 18:27
@TheAlmightyBob TheAlmightyBob force-pushed the fix-ios-nullish-coalescing-operator-support branch from 9979a98 to c73b925 Compare May 11, 2024 20:31
@TheAlmightyBob TheAlmightyBob force-pushed the fix-ios-nullish-coalescing-operator-support branch from c73b925 to 99936ca Compare May 11, 2024 22:12
@TheAlmightyBob TheAlmightyBob merged commit d5749e0 into react-native-webview:master May 11, 2024
11 checks passed
react-native-community-bot pushed a commit that referenced this pull request May 11, 2024
## [13.10.2](v13.10.1...v13.10.2) (2024-05-11)

### Bug Fixes

* **iOS:** Replace unsupported nullish coalescing operator for older iOS versions ([#3388](#3388)) ([d5749e0](d5749e0))
@react-native-community-bot
Copy link
Collaborator

🎉 This PR is included in version 13.10.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants