New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android & iOS] Support of window.print()
function
#3318
base: master
Are you sure you want to change the base?
[Android & iOS] Support of window.print()
function
#3318
Conversation
window.print()
functionwindow.print()
function
Would love to see this applied. We've been fighting this printing issue on ios for a while. |
@scamp81 Unfortunately, I can't say yet it completely works on iOS — I still haven't figured out how, and whether it is possible to print there the entire page, rather than just the visible WebView viewport. On macOS I kind of found a way to make it work, but that goes against Apple docs on how snapshot config is supposed to work, and it does not work the same on iOS, so... perhaps I overlooked something and I neither have a good solution for macOS. As usual, it just works on Android — iOS software & APIs suck!!! 🤣 |
# Conflicts: # apple/RNCWebViewImpl.m
Update: Now it feels I have figured out the right way to do the printing on iOS. Turns out to be quite straightforward, but not easy to figure out starting from WKWebView documentation, neither I saw that right solution in StackOverflow answers to the writing questions :( The PR is updated accordingly. |
Hi @birdofpreyru As far as I can see, this PR is still pending merging. |
Hi @jamonholmgren @Titozzz |
@frontendguru1 , you might want to consider switching to my fork of react-native-webview — I got tired of waiting while this, and a few other PRs of mine with critical fixes, gets merged-in (the first of them is pending since Jan 16, 2024), and after depending on a locally built, patched version of |
Yes, I am also planning to switch to updated version.
Have you published this to NPM?
Sent from Gmail Mobile
…On Mon, 19 Feb 2024 at 9:41 PM, Dr. Sergey Pogodin ***@***.***> wrote:
@frontendguru1 <https://github.com/frontendguru1> , you might want to
consider switching to my fork of react-native-webview
***@***.***/react-native-webview> — I got
tired of waiting while this, and a few other PRs of mine with critical
fixes, gets merged-in (the first of them is pending since Jan 16, 2024),
and after depending on a locally built, patched version of
react-native-webview in my projects, I decided it is a high time to
publish my fork to NPM.
—
Reply to this email directly, view it on GitHub
<#3318 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFKS2XTAQMWXHAQWJ2YTGLYUN2RNAVCNFSM6AAAAABC2MKTQGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJSG44DGNZWGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
Yeap. |
Cool
Could you please share the URL of this?
Sent from Gmail Mobile
…On Mon, 19 Feb 2024 at 10:01 PM, Dr. Sergey Pogodin < ***@***.***> wrote:
Have you published this to NPM?
Yeap.
—
Reply to this email directly, view it on GitHub
<#3318 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFKS2TTAMFGTNC6B62B55DYUN47BAVCNFSM6AAAAABC2MKTQGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJSHAZTIMJXGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
Thanks!
Sent from Gmail Mobile
…On Mon, 19 Feb 2024 at 10:05 PM, Dr. Sergey Pogodin < ***@***.***> wrote:
***@***.***/react-native-webview
—
Reply to this email directly, view it on GitHub
<#3318 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFKS2XS47WBTQ2SPXDMOA3YUN5L3AVCNFSM6AAAAABC2MKTQGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJSHA2DIMBYG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
@Titozzz could you please review this PR? |
@birdofpreyru |
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically |
Right, bot, three months later maintainers still haven’t found time to merge in my PR; in the meantime I’ve already started my fork of this library — a few steps ahead of the upstream, and could be even better, if anybody backed me up financially. |
#3317