Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3289] Android: Trigger onError callback on asset loading errors #3290

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

birdofpreyru
Copy link

Here is my PR for #3289:

  • Avoids using the deprecated version of onReceivedError for onError implementation on Android.
  • Fires onError callback, if provided, for asset loading errors, in addition to the primary source loading errors.
  • Does not alter the logic of other related callbacks (onLoad, onLoadEnd, etc.); i.e. onError signals triggered for page assets do not prevent onLoad and onLoadEnd to be fired for the page itself, if that was loaded — thus, the page is signaled to have been loaded successfully, even if its assets failed to load, and that is just the original behavior of those signals before my PR.

Can we merge it, please? :)

@Titozzz
Copy link
Collaborator

Titozzz commented Jan 29, 2024

Note to self: Maybe release as breaking as we will trigger more errors

@gmartpad
Copy link

gmartpad commented Mar 22, 2024

When will these changes be added to a new version of react-native-webview? This might actually solve a problem where my page eternally loads because of assets failing to load, and onLoadEnd never triggers.

Copy link

Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically

@github-actions github-actions bot added the Stale label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants