fix: support iOS 16+ for menuItems #3269

[hoangduy0610]

No description provided.

[hoangduy0610]

#3269 this issue

[thaibm]

Nice change! Really helpful.

[hoangduy0610]

@chiaramooney please take a look of this PR

[chiaramooney]

I only maintain the Windows code of the module. @Titozzz might be able to help.

[hoangduy0610]

I only maintain the Windows code of the module. @Titozzz might be able to help.

I haven't received any reply from him. Is there anything I missed?

[Titozzz]

I'm just missing some time but I'll get to it I promise

[hoangduy0610]

how is it going, mr @Titozzz ? ^_^ Hope to receive feedback from you soon. My project was blocking by this and I must patch package manually, so I think this PR will be helpful for others. Thank you so much

[Titozzz]

Hey! I started cleaning stuff last weekend so hopefully I'll get to it soon! Thanks for being polite and understanding 🤗

Regarding patch-package, yeah that's what we all do, waiting for our PRs to get merged, it's a good practice ✌️.

(I know it's a little more maintenance so hopefully you ping the maintainer every now and then ❤️)

[hoangduy0610]

@TheAlmightyBob I updated the code, please take a look when you available. Thank you so much <3

[hoangduy0610]

@TheAlmightyBob @Titozzz Hi there, I'm still waiting for approval.

P/s: Don't be mad at me, I just want to notify you.

[Titozzz]

No worries, as long as it's once in a while and friendly it's good to nudge me 🥰

Added to Monday todo

[Saadnajmi]

@TheAlmightyBob @Titozzz Hi there, I'm still waiting for approval.

P/s: Don't be mad at me, I just want to notify you.

I wonder if this if already fixed by my earlier PR: #3373

[Titozzz]

@hoangduy0610 Can you confirm if this is still needed after @Saadnajmi PR ?

[hoangduy0610]

Hi @Titozzz , I confirm that this is already fixed in @Saadnajmi PR. Thank you so much. I will close my PR.