fix(Android): Apply WebView settings before loading content - take 2 #2772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…guish the "require(...)" case from the "uri: 'file://...'" case (saying "import" instead of "require" just because "require" is too vague a word...)
…WebView on Android, because otherwise we start loading the content before relevant WebView settings have been applied (for example, allowFileAccess, meaning that initial loading of local files would fail) (this is not an Android-specific requirement, but "source" was already at the end for other platforms)
…de the local file test on Windows/Mac
TheAlmightyBob
requested review from
Titozzz and
jamonholmgren
as code owners
|
Since the CI passed, I've pushed this change to #2766 and am closing this PR in favor of that one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #2766 but using
react-native-blob-utilinstead ofreact-native-file-access, because I couldn't get the latter to build with macOS.I'm not certain yet if this will work, mainly creating a PR to test it with the CI.