chore: migrate to react-native-test-app #2148
Conversation
|
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically |
|
This is currently blocked by #2218. I will rebase and continue working on this after it's merged. |
|
I've already reverted the 0.65 bump in f8a1ba2, isn't that enough ? |
Ah, I had missed this. But I think this is still going to be problematic because react-native dependencies are now out of sync. We have react-native 0.65 pulling in react 17 and cli 6, which again pulls in metro 0.66. react-native-windows is still on 0.62, which won't work with react 17 or metro above 0.60. react-native-macos is even further behind. I think we still need to downgrade. The best we can do is 0.64, since react-native-macos is still lagging behind on releases. What do you think? |
|
Regardless, this is going to be a pretty big undertaking 😕 |
|
Well, I do think react-native should almost always be latest in the devDeps 👀... Just to make sure the libs works with the latest versions.. but I'm not sure what's the best path forward. We should check what other libs are doing |
I think you can still test the latest versions, but that should be on CI if possible. You can bump to latest, and disable the incompatible packages. This is how we do it in react-native-test-app: https://github.com/microsoft/react-native-test-app/blob/a18cf3418a87d1b2355113cfee6b676e53ca500e/scripts/set-react-version.js#L41-L48 Otherwise, AsyncStorage is still on an older version because of this: https://github.com/react-native-async-storage/async-storage/blob/0ec517c3b6e0020c4edc5a59519c4e3938707d76/package.json#L88 react-native-menu is still on 0.64: https://github.com/react-native-menu/menu/blob/191a1f73416329887275d6ebcfa8fb0974e2f90a/package.json#L58 |
|
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically |
|
Updated description with remaining work. @Titozzz, let me know what you think. Happy to discuss this further. |
|
I've merged the PR to fix macOS, anything else I can do to help ? |
One thing I missed in the list above is re-enabling macOS on CI. Do you know if this has ever existed? Would it be something you can bring back? I have another branch with the react-native-macos bump, but I'm blocked by an issue where it thinks it's on 0.63 instead of 0.62 and refuses to load the JS. This was last night and I haven't investigated further. Edit: Thanks for the quick merge ❤️ |
- Android test app now requires JDK 11 - Bump react-native* to 0.64 - Bump jest to 26.6.3 - Bump typescript to 4.5.5
tido64
force-pushed
the
tido/migrate-rnta
branch
2 times, most recently
from
1a2ab8c
to
6a5bd63
Compare
tido64
force-pushed
the
tido/migrate-rnta
branch
from
6a5bd63
to
d195ad8
Compare
tido64
force-pushed
the
tido/migrate-rnta
branch
from
d195ad8
to
c2c6629
Compare
|
With @chiaramooney's help, I was able to get the Windows test app booting again. I'm still trying to figure out the CI deploy failure, but the changes should be ready for review now. |
tido64
force-pushed
the
tido/migrate-rnta
branch
from
0ef86f7
to
3f5aac6
Compare
|
@Titozzz: Can you please review this when you have time? With this, we will have bumped react-native to 0.64 on all platforms. After this lands, we will submit another PR to bump to 0.66. I think we should also consider adding CI for building Android/iOS/macOS. |
* master: (32 commits) chore: configure Metro to consume source directly (react-native-webview#2395) ci: build Android/iOS/macOS test apps on CI (react-native-webview#2383) chore: bump react-native to 0.66 (react-native-webview#2380) docs: update the contributing guide on how to build/start the test apps (react-native-webview#2381) chore: migrate to react-native-test-app (react-native-webview#2148) chore(release): 11.17.2 [skip ci] fix(types): Mark android-only methods as possibly undefined (react-native-webview#2362) chore(docs): add more details on onContentProcessDidTerminate (react-native-webview#2368) Fixes to cookie sync (react-native-webview#2193) chore(deps): bump react-native-macos to 0.62 (react-native-webview#2314) chore(docs): Portuguese documentation translation (react-native-webview#2354) chore(docs): Update of the links to the READMEs (react-native-webview#2336) chore(release): 11.17.1 [skip ci] fix(android): Prevent crash from unsupported URI downloads (react-native-webview#2328) chore(docs): Add French translation for the README (react-native-webview#2332) chore(release): 11.17.0 [skip ci] feat(ios): Add textInteractionEnabled prop (react-native-webview#2252) chore(release): 11.16.0 [skip ci] feat(android): add minimum font size (react-native-webview#2279) chore(release): 11.15.2 [skip ci] ...
|
🎉 This PR is included in version 11.18.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
* chore: migrate to react-native-test-app - Android test app now requires JDK 11 - Bump react-native* to 0.64 - Bump jest to 26.6.3 - Bump typescript to 4.5.5 * unbreak Windows build * fix Windows autolink * don't use nuget and default to x64 * add logging during deploy * restore certificate for deployment * update app id * reuse appxmanifest
* chore: migrate to react-native-test-app - Android test app now requires JDK 11 - Bump react-native* to 0.64 - Bump jest to 26.6.3 - Bump typescript to 4.5.5 * unbreak Windows build * fix Windows autolink * don't use nuget and default to x64 * add logging during deploy * restore certificate for deployment * update app id * reuse appxmanifest
Migrate test apps to
react-native-test-app.Remaining work:
autolink-windowsdoesn't findRNCWebView