Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SSL error handling for Android WebView #1450

Merged
merged 2 commits into from Jun 13, 2020
Merged

Add SSL error handling for Android WebView #1450

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d36c97
Add SSL error handling for Android WebView
alesandroortiz Jun 10, 2020
3074d54
Merge branch 'master' into add-ssl-error-handling
alesandroortiz Jun 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
46 changes: 46 additions & 0 deletions android/src/main/java/com/reactnativecommunity/webview/RNCWebViewManager.java
View file
Open in desktop
Expand Up @@ -10,6 +10,7 @@
import android.graphics.Bitmap;
import android.graphics.Color;
import android.Manifest;
import android.net.http.SslError;
import android.net.Uri;
import android.os.Build;
import android.os.Environment;
Expand All @@ -26,6 +27,7 @@
import android.webkit.DownloadListener;
import android.webkit.GeolocationPermissions;
import android.webkit.JavascriptInterface;
import android.webkit.SslErrorHandler;
import android.webkit.PermissionRequest;
import android.webkit.URLUtil;
import android.webkit.ValueCallback;
Expand Down Expand Up @@ -797,6 +799,50 @@ public boolean shouldOverrideUrlLoading(WebView view, WebResourceRequest request
return this.shouldOverrideUrlLoading(view, url);
}

@Override
public void onReceivedSslError(final WebView webView, final SslErrorHandler handler, final SslError error) {
handler.cancel();

int code = error.getPrimaryError();
String failingUrl = error.getUrl();
String description = "";
String descriptionPrefix = "SSL error: ";

// https://developer.android.com/reference/android/net/http/SslError.html
switch (code) {
case SslError.SSL_DATE_INVALID:
description = "The date of the certificate is invalid";
break;
case SslError.SSL_EXPIRED:
description = "The certificate has expired";
break;
case SslError.SSL_IDMISMATCH:
description = "Hostname mismatch";
break;
case SslError.SSL_INVALID:
description = "A generic error occurred";
break;
case SslError.SSL_NOTYETVALID:
description = "The certificate is not yet valid";
break;
case SslError.SSL_UNTRUSTED:
description = "The certificate authority is not trusted";
break;
default:
description = "Unknown SSL Error";
break;
}

description = descriptionPrefix + description;

this.onReceivedError(
webView,
code,
description,
failingUrl
);
}

@Override
public void onReceivedError(
WebView webView,
Expand Down