Feat/ts

[tcodes0]

Overview

see #805
Introduces typescript to project

Test Plan

run yarn validate:ts

todo

• deps and config
• components/
• eslint-typescript configuration, should fix ci
• figure out how to build ts for npm
• type index.js (maybe in another pr)
• flow: remove?
• read bridge and double check types

[tcodes0]

Do we want TS to emit types and declarations or just type-check?

[mikehardy]

Ohhh 🤤
Your question on emitting types and declarations: I think one of the stated goals of the conversion is to be the source of truth for typing (so that people don't need to import from definitely typed). In order to do that we must necessarily emit the types and declarations I think?

[tcodes0]

@MateusAndrade on a good spot for a review, specially around the ts-ignore stuffs

[MateusAndrade]

This looks great @Thomazella. I have some considerations about splitting the types from the main file into different files, something like types.d.ts or index.d.ts. By doing this we would need to export the types letting this easier to use outside the library.

Also, we don't need to declare a namespace or something similar to that? 🤔

[tcodes0]

I'm hoping we can emit that file using the source code as base.

[mikehardy]

Yep - device-info emits the file for what it's worth, using bob as a build tool it just happens?
I'm not really watching this closely so nothing just wanted to say in general, nice work :-), I'm excited to see the result

[tcodes0]

So the last thing is to build the js with tsc, and double check types. I think we'll get the .d.ts files "for free" like that, which should make it easier to maintain. I think it may make sense to type the bridge stuff too, but we'd probably need to do that in a file and maintain it. Maybe another PR for that. Overall we're close.

[mikehardy]

All of that should be for free with bob I think here is the stanza from device info https://github.com/react-native-community/react-native-device-info/blob/master/package.json

  "@react-native-community/bob": {
    "source": "src",
    "output": "lib",
    "targets": [
      "commonjs",
      "module",
      "typescript"
    ]
  }

[tcodes0]

@mikehardy ok, didn't know bob, I get it now. Thanks!

[luancurti]

@Thomazella what's the status of this PR? Do you need some help?

[tcodes0]

@luancurti nope, should be able to finish, will aim for this week. I was just busy with my new job that's all.

[MateusAndrade]

@luancurti nope, should be able to finish, will aim for this week. I was just busy with my new job that's all.

Let me know if you need any help. 👯

[DanielMarkiel]

@MateusAndrade , @tcodes0
What's the status of this PR? Is it stale (nothing has changed since Jul 13, 2020)?
If yes, would you mind if I try completing it next week?

[tcodes0]

feel free to complete it :)

[MateusAndrade]

@MateusAndrade , @tcodes0
What's the status of this PR? Is it stale (nothing has changed since Jul 13, 2020)?
If yes, would you mind if I try completing it next week?

Let me know if there is anything we can do to help. 🚀

[MateusAndrade]

Thanks a lot, guys, we merged #1001 and successfully published it under the version v6.0.0. 🚀