Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support RN 0.74 and Bridgeless #551

Merged

Conversation

alanjhughes
Copy link
Contributor

@alanjhughes alanjhughes commented Mar 7, 2024

Update library to work with react native 0.74 and bridgeless. The main changes being

  • The removal of FabricViewStateManager.HasFabricViewStateManager and replacing it with StateWrapper
  • Some changes to c++ function arguments and using c++20
  • Add the same .clang-format that react native uses to clean up some formatting issues.

Tested on

  • Old arch ✅
  • New arch
    • with bridgeless enabled
      • iOS ✅
      • Android ✅
    • with bridgeless disabled
      • iOS ✅
      • Android ✅

Note: There is currently a bug in RC2 that causes an error on android when using the new arch with bridgeless disabled. This will be resolved in RC3
Issue has been resolved in RC3 and I have bumped the example. Everything is working correctly now

@alanjhughes alanjhughes changed the title @alanhughes/bridgeless Support RN 0.74 and Bridgeless Mar 7, 2024
@brentvatne
Copy link

looking forward to this landing and getting us one step closer to new arch support in the ecosystem!

@brentvatne brentvatne changed the title Support RN 0.74 and Bridgeless feat: Support RN 0.74 and Bridgeless Mar 22, 2024
@brentvatne brentvatne merged commit 3604301 into react-native-picker:master Mar 22, 2024
2 of 12 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 22, 2024
# [2.7.0](v2.6.1...v2.7.0) (2024-03-22)

### Features

* Support RN 0.74 and Bridgeless ([#551](#551)) ([3604301](3604301))
@Naturalclar
Copy link
Contributor

🎉 This PR is included in version 2.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@DavideViolante
Copy link

I think this PR is causing #555 #556 #557

@tortuvshin
Copy link

I think this PR is causing #555 #556 #557

I faced the same error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants