-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(android): use new Advanced Markers instead of deprecated ones #5039
Open
mateki0
wants to merge
11
commits into
react-native-maps:master
Choose a base branch
from
TheWidlarzGroup:feat/android-advanced-markers
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(android): use new Advanced Markers instead of deprecated ones #5039
mateki0
wants to merge
11
commits into
react-native-maps:master
from
TheWidlarzGroup:feat/android-advanced-markers
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mateki0 awesome work, but I wouldn't rush in merging this because it's rather a critical change and needs some thoughtful considerations. what comes to mind, and should make the implementation better:
|
salah-ghanim
requested changes
May 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check previous
Nice suggestions :)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does any other open PR do the same thing?
No
What issue is this PR fixing?
#4481
There are few problems with markers currently: poor performance, blinking, etc.
How did you test this PR?
I have added new example screen MarkersCollisionBehavior in which I've used one of new features available only in Advanced Markers.
Also I have fixed AnimatedMarkerPosition screen on Android in which you can test animating to coordinates.
AdvancedMarkers will be used by default if we pass googleMapId and if it's supported by device.
Some devices might not support the new map renderer and therefore cannot display advanced markers and in this case we we will use old Markers.