Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react-native-libraries.json #930

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

arpit-bhalla
Copy link

@arpit-bhalla arpit-bhalla commented Jan 5, 2023

πŸ“ Why & how

React Native Elements v4 is renamed to @rneui/themed

βœ… Checklist

  • Added library to react-native-libraries.json

Copy link
Member

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @arpit-bhalla, React Native Elements is already listed in the directory, and CI fails because you are trying to add the duplicate entry for it:

I can see that the project structure has changed, it is now a mono repo with the separated and renamed packages in there. In this case we probably should update the current entry to point to @rneui/base and then add @rneui/themed as an additional package.

@arpit-bhalla
Copy link
Author

Can we keep RNE(v3) as React Native Elements and add base and themed for v4?

@Simek
Copy link
Member

Simek commented Jan 7, 2023

If the repository is the same for the v3 and v4 it is not possible to have multiple, separate entries ATM.

What's the motivation for this split?

@arpit-bhalla
Copy link
Author

arpit-bhalla commented Jan 7, 2023

@Simek themed is just wrapping base components with theme

@Simek
Copy link
Member

Simek commented Jan 7, 2023

Sorry for not being clear enough, I have meant the separation of versions, so v3 and v4.

Why do you think it will be beneficial to have both versions at the same time? Is something wrong with making the current entry @rneui/base?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants