Add the Formorama library #504
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simek
requested changes
Nov 19, 2020
There was a problem hiding this comment.
Hi @dezemand, I'm not able to see any mention about react-native-web, react-native-macos or react-native-windows in the docs or package repository. There is also no example, so I'm cannot accept the out-of-tree platforms support without the confirmation that they are indeed supported.
The example link should also lead to the working code example, not the code snippets in the docs.
Also the nameOverride field is redundant in case of your package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This library can be used in React Native to manage your forms.
Checklist
If you added a new library: