ci: skip windows e2e tests in specific scenario #2386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szymonrybczak
requested review from
adamTrz,
thymikee and
cipolleschi
as code owners
szymonrybczak
force-pushed
the
ci/run-win-e2e-only-in-specific-scenario
branch
3 times, most recently
from
57503fe
to
d8461c7
Compare
szymonrybczak
force-pushed
the
ci/run-win-e2e-only-in-specific-scenario
branch
2 times, most recently
from
09f4195
to
7d31fad
Compare
szymonrybczak
force-pushed
the
ci/run-win-e2e-only-in-specific-scenario
branch
from
7d31fad
to
7785f6a
Compare
|
As discussed with @TMisiukiewicz this Pull Request needs to be first merged to work correctly - Windows shouldn't be triggered when there's only change in |
thymikee
reviewed
May 12, 2024
| @@ -17,3 +17,4 @@ export {default as installPods} from './tools/installPods'; | |||
|
|
|||
| export {default as findXcodeProject} from './config/findXcodeProject'; | |||
| export {default as findPbxprojFile} from './config/findPbxprojFile'; | |||
| console.log('hello'); | |||
thymikee
reviewed
May 12, 2024
| with: | ||
| list-files: shell | ||
| filters: | | ||
| specific_dir: |
There was a problem hiding this comment.
Let’s rename this to something like „apple_dirs” in a follow-up PR and adjust the name of the job. „Changes” is super ambiguous.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When there's a change only in
cli-platform-appleorcli-platform-iosit doesn't make sense to triger also Windows jobs, because there's no scenario that change in these packages would broke Windows builds.Test Plan:
If there's only a change in
cli-platform-appleorcli-platform-iosWindows jobs shouldn't be triggered.Checklist