perf(autolinking)!: prioritise files with *Package.java|*Package.kt in getPackageClassName
#2384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in `getPackageClassName`
tido64
reviewed
May 8, 2024
|
|
||
| // @ts-ignore | ||
| return packages.length ? packages[0][1] : null; | ||
| } | ||
|
|
||
| function getClassNameMatches(files: string[], folder: string) { | ||
| return files | ||
| .map((filePath) => fs.readFileSync(path.join(folder, filePath), 'utf8')) |
There was a problem hiding this comment.
I wonder if streaming is faster than reading the whole file every time: https://tangledeveloper.medium.com/how-to-read-file-line-by-line-efficiently-in-node-js-8125fe5bd185
There was a problem hiding this comment.
worth to measure definitely, these declarations are usually somewhere at the top of the file so it hints some potential
There was a problem hiding this comment.
Replacing glob.sync above with glob.stream might also be worth looking into, but making everything async might turn this into a very big PR 😛
satya164
reviewed
May 9, 2024
| .map(matchClassName) | ||
| .filter((match) => match); | ||
| if (!packages.length) { | ||
| files = getMainActivityFiles(folder, false); |
There was a problem hiding this comment.
maybe there's scope to exclude previously matched files from this list not to read same files twice
There was a problem hiding this comment.
nice! good catch
cortinico
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This Pull Request changes schema that looks for files to check to find class name, after my tests in various application the match results were included almost in every library in files with
Packageat the end. But our previous logic was going through every file in library with.ktand.javaextension until it found file withimplements ReactPackage, some libraries can have 100+ files and we were reading them until we matched relevant Regex schema 😅I also added a fallback which checks files with
*.ktand*.javaextensions if it couldn't findimplements ReactPackagein file with*Packageat the end, which ensures us that we don't introduce any breaking change. The output ofconfigcommand stays the same.Performance improvement
I did a test in Expensify app, which is an open-source app with 50 libraries containing native code. Before my changes, we were reading 490 files to find the class name. Right now, we only check 79 (still there's a room for improvements).
Test Plan:
The
dependenciesfield should be the same as before.Checklist