feat: use native fetch from node #2381
Open
+49
−42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When using CLI with Node >= 21, there are deprecation warnings showing up in console, which can be traced to
whatwg-url@5.0.0
which is a dependency ofnode-fetch
. I've replacednode-fetch
with nativefetch
from Node. Since Node18, the fetch is no longer under experimental flag, and since Node21 it's marked as stable.Remarks:
@types/opentype.js
package as it was polluting global context with DOM typesfetchToTemp
usedstream.Readable.fromWeb
which is still marked as experimental but we only use use it inside ofcli-doctor
so the impact is relatively lowTest Plan:
Checklist