chore(run-android): deprecate --deviceId in favour of --device
#2377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
docs
|
Unfortunately, to my knowledge, |
thymikee
reviewed
May 8, 2024
| @@ -122,6 +123,13 @@ async function getAvailableDevicePort( | |||
|
|
|||
| // Builds the app and runs it on a connected emulator / device. | |||
| async function buildAndRun(args: Flags, androidProject: AndroidProject) { | |||
| if (args.deviceId) { | |||
| logger.warn( | |||
| 'The `deviceId` parameter is deprecated. Please use `device` instead.', | |||
There was a problem hiding this comment.
Suggested change
| 'The `deviceId` parameter is deprecated. Please use `device` instead.', | |
| 'The `deviceId` parameter is renamed to `device`. Please use the new `device` argument next time to avoid this warning.', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
To avoid confusion between
run-androidandrun-ios, I deprecated--device-idin favour of--device. When someone will use--device-id` a warning will be presented, so that users can migrate their scripts.Test Plan:
node /path/to/react-native-cli/packages/cli/build/bin.js run-android --deviceId "asdf"Should give the warning and pass id the same way as before.
3. Run this command:
node /path/to/react-native-cli/packages/cli/build/bin.js run-android --device "asdf"Should launch an app on passed id.
Checklist