Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update the diff link at update check to show both the old and new versions #2373

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

coder-xiaomo
Copy link

Summary:

When the newer ReactNative version comes out, we can see some info at console like this:

info React Native v0.74.1 is now available (your project is running on v0.73.6).
info Changelog: https://github.com/facebook/react-native/releases/tag/v0.74.1
info Diff: https://react-native-community.github.io/upgrade-helper/?from=0.74.1
info For more info, check out "https://reactnative.dev/docs/upgrading?os=windows".
info Dev server ready

but the Diff link can accept both old version and new version like this:

info Diff: https://react-native-community.github.io/upgrade-helper/?from=0.73.6&to=0.74.1

This is what this pr solved

Test Plan:

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@coder-xiaomo coder-xiaomo changed the title update the diff link at update check to show both the old and new versions fix: update the diff link at update check to show both the old and new versions May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant