Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use preferred device in default mode #2363

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

szymonrybczak
Copy link
Collaborator

Summary:

In #2162 I added preferred device feature - it saves device id to cache, and then when running run-ios command it'll push preferred device to the beginning.

For some strange reason, we only enabled this for --interactive or --list-devices mode. In this Pull Request preferred device is also in default mode.

Test Plan:

  1. Clone the repository and do all the required steps from the Contributing guide
  2. Run run-ios --interactive pick a simulator
  3. Open bunch other simulators
  4. Run this command:
node /path/to/react-native-cli/packages/cli/build/bin.js run-ios
  1. It should pick one that was selected in the interactive prompt.

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@szymonrybczak
Copy link
Collaborator Author

For some reason Windows Job is failing - all passes locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant