feat: RFC-0759 break apart iOS auto-linking #2335
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of native_modules serving `use_native_modules!(config)`, users should now use `autolink_native_modules!()` from autolinking.rb. This is being used in react-native-community/template#7
blakef
changed the title
cortinico
reviewed
Mar 19, 2024
Comment on lines
+6
to
+8
| # 15.0.0-alpha.1 (2024-03-15) | ||
|
|
||
| feat: added autolinking.rb, which breaks up use_native_modules! into list_native_modules!, and link_native_modules! (which lives in react-native). |
There was a problem hiding this comment.
I'm unusre we're actually using this CHANGELOG file 🤔
There was a problem hiding this comment.
True, we're not adding CHANGELOG inside this repo.
Comment on lines
+94
to
+97
| # You should be using this instead of use_native_modules, which is deprecated. | ||
| def autolink_native_modules!() | ||
| link_native_modules! list_native_modules!() | ||
| end |
There was a problem hiding this comment.
Can we achieve the same without having to go through a deprecation cycle but by just changing the import path for the use_native_modules function?
There was a problem hiding this comment.
I spoke with @cipolleschi about the design, and I've leaning towards what you've described: keep the use_native_modules API to avoid a deprecation cycle / effort from our users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Instead of native_modules serving
use_native_modules!(config), users should now useautolink_native_modules!()from autolinking.rb.This is being used in react-native-community/template#7
Warning
This needs to wait for nightlies to land with the updated TypeScript definitions, expect CI to fail until then.
Test Plan:
Checklist