feat: RFC-0759: command init for iOS → @react-native/core-cli-utils #2332
Conversation
Use the core library for iOS init actions.
blakef
force-pushed
the
rfc-0759-init-command
branch
from
99a8fdf
to
bde2bae
Compare
| @@ -8,6 +8,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@react-native-community/cli-tools": "14.0.0-alpha.0", | |||
| "@react-native/core-cli-utils": "nightly", | |||
There was a problem hiding this comment.
Same as for Android PR, this needs to be updated once we have the first RC out
There was a problem hiding this comment.
@cortinico could you please add me, @szymonrybczak and @TMisiukiewicz as Codeowners for @react-native/core-cli-utils and other former CLI folders? This would make it easier for us to track changes and participate in discussions and development of these
There was a problem hiding this comment.
We don't use CODEOWNERS for react-native sadly
| shouldHandleRepoUpdate: false, | ||
| newArchEnabled: options?.newArchEnabled, |
There was a problem hiding this comment.
The ...options: RunPodInstallOptions includes whether newArchEnabled has been configured on / off.
There was a problem hiding this comment.
Great thanks for the clarification
|
Trying to get my head around the logic of installing pods under various conditions. Is this a temporary step? Because it moves some of the logic to the core, but not most of it. Other than that and lack of types (which we can ts-expect-error and ship later) it seems to work when linked locally |
Thanks for taking a look at this @thymikee. Appreciate the feedback. What sort of things would you have expected to move into core that aren't there? Both flow and TypeScript types ship with the @react-native/core-cli-utils package. |
|
Since we have TS typings, can we rebase and hopefully get it merged? |
Summary:
Use the core library for iOS init actions.
Warning
This needs to wait for nightlies to land with the updated TypeScript definitions, expect CI to fail until then.
Test Plan:
Checklist