Bump execa from 1.x to 5.x #1888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mind looking at the CI error on linux? |
https://github.com/sindresorhus/execa/releases 5.x is the last version before the package is being rewritten to ESM. execa now ships with typescript types embedded. I see a previous attempt here was aborted: react-native-community#1514 Relevant breaking changes: error.code is deprecated in favor of error.exitCode sindresorhus/execa#250 Some changes to stripping the final newline: sindresorhus/execa@f8397ba
thymikee
approved these changes
Mar 27, 2023
There was a problem hiding this comment.
Thank you! @szymonrybczak mind give it a quick test? Then we're good to merge
adamTrz
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
https://github.com/sindresorhus/execa/releases
5.x is the last version before the package is being rewritten to ESM.
execa now ships with typescript types embedded.
I see a previous attempt here was aborted:
#1514
Relevant breaking changes:
error.code is deprecated in favor of error.exitCode
sindresorhus/execa#250
Some changes to stripping the final newline:
sindresorhus/execa@f8397ba
Test Plan:
There should be no expected changes. From reading the Changelog I could not find any usage of deprecated APIs.