Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to bundle size issue in README #175

Merged
merged 1 commit into from
Aug 22, 2018

Conversation

curran
Copy link
Contributor

@curran curran commented Aug 14, 2018

Since this project requires a specific Webpack configuration prioritizing .mjs files, and that configuration is not (yet) standard across most, large bundle size will be a common issue encountered for newcomers. Therefore, it may be nice to link to this issue in the README where the ES6 imports are recommended.

This PR adds a change to the README pointing users to that issue, in the section where the old format and new format are compared.

Related to #154

@kamijin-fanta kamijin-fanta merged commit d92ae0e into react-icons:master Aug 22, 2018
@kamijin-fanta
Copy link
Member

thanx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants